fix security issue: remove weights_only=False for multimodal example#4104
Open
faradawn wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix security issue: remove weights_only=False for multimodal example#4104faradawn wants to merge 1 commit intoNVIDIA:mainfrom
faradawn wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Hardcoding weights_only=False is a security risk as it allows arbitrary code execution. Users who need legacy checkpoint loading should opt in via TORCH_FORCE_NO_WEIGHTS_ONLY_LOAD=1. Signed-off-by: Faradawn Yang <73060648+faradawn@users.noreply.github.com>
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
faradawn
changed the title
Contributor
Author
|
/ok to test ee49dfc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix security issue: https://nvbugspro.nvidia.com/bug/5996966
weights_only=Falsefromtorch.loadinexamples/multimodal/combine_state_dicts.py(introduced in Multimodal: add load weights only #3452)TORCH_FORCE_NO_WEIGHTS_ONLY_LOAD=1